Myzel394/Alibi
1
0
Fork 0
mirror of https://github.com/Myzel394/Alibi.git synced 2025-06-19 07:15:25 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: Add workaround for DisposableEffect

Browse Source 
Signed-off-by: Myzel394 <50424412+Myzel394@users.noreply.github.com>
This commit is contained in:
Myzel394 2024-03-30 22:47:09 +01:00
parent 14d6b36162
commit 798b6f2119
No known key found for this signature in database
GPG Key ID: DEC4AAB876F73185
1 changed files with 44 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
app/src/main/java/app/myzel394/alibi/ui/components/RecorderScreen/organisms/RecorderEventsHandler.kt
View File

@ -291,8 +291,17 @@ fun RecorderEventsHandler(
} }
// Register video recorder events // Register video recorder events
// Absolutely no idea, but somehow on some devices the `DisposableEffect`
// is registered twice, and THEN disposed once (AFTER being called twice),
// which then causes the `onRecordingSave` to be in a weird state.
// This variable is a workaround to prevent this from happening.
var alreadyRegistered = false
DisposableEffect(Unit) { DisposableEffect(Unit) {
Log.d("Alibi", "===== Registering videoRecorder events $videoRecorder") if (alreadyRegistered) {
onDispose { }
} else {
alreadyRegistered = true
Log.i("Alibi", "===== Registering videoRecorder events $videoRecorder")
videoRecorder.onRecordingSave = { cleanupOldFiles -> videoRecorder.onRecordingSave = { cleanupOldFiles ->
saveRecording(videoRecorder as RecorderModel, cleanupOldFiles) saveRecording(videoRecorder as RecorderModel, cleanupOldFiles)
} }
@ -327,13 +336,14 @@ fun RecorderEventsHandler(
} }
onDispose { onDispose {
Log.d("Alibi", "===== Disposing videoRecorder events") Log.i("Alibi", "===== Disposing videoRecorder events")
videoRecorder.onRecordingSave = { videoRecorder.onRecordingSave = {
throw NotImplementedError("onRecordingSave should not be called now") throw NotImplementedError("onRecordingSave should not be called now")
} }
videoRecorder.onError = {} videoRecorder.onError = {}
} }
} }
}
if (isProcessing) if (isProcessing)
RecorderProcessingDialog( RecorderProcessingDialog(