Myzel394/Alibi
1
0
Fork 0
mirror of https://github.com/Myzel394/Alibi.git synced 2025-06-18 23:05:26 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: Add workaround for DisposableEffect

Browse Source 
Signed-off-by: Myzel394 <50424412+Myzel394@users.noreply.github.com>
This commit is contained in:
Myzel394 2024-03-30 22:47:09 +01:00
parent 14d6b36162
commit 798b6f2119
No known key found for this signature in database
GPG Key ID: DEC4AAB876F73185
1 changed files with 44 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

78
app/src/main/java/app/myzel394/alibi/ui/components/RecorderScreen/organisms/RecorderEventsHandler.kt
View File

@ -291,47 +291,57 @@ fun RecorderEventsHandler(
} }
// Register video recorder events // Register video recorder events
// Absolutely no idea, but somehow on some devices the `DisposableEffect`
// is registered twice, and THEN disposed once (AFTER being called twice),
// which then causes the `onRecordingSave` to be in a weird state.
// This variable is a workaround to prevent this from happening.
var alreadyRegistered = false
DisposableEffect(Unit) { DisposableEffect(Unit) {
Log.d("Alibi", "===== Registering videoRecorder events $videoRecorder") if (alreadyRegistered) {
videoRecorder.onRecordingSave = { cleanupOldFiles -> onDispose { }
saveRecording(videoRecorder as RecorderModel, cleanupOldFiles) } else {
} alreadyRegistered = true
videoRecorder.onRecordingStart = { Log.i("Alibi", "===== Registering videoRecorder events $videoRecorder")
snackbarHostState.currentSnackbarData?.dismiss() videoRecorder.onRecordingSave = { cleanupOldFiles ->
} saveRecording(videoRecorder as RecorderModel, cleanupOldFiles)
videoRecorder.onError = {
scope.launch {
saveAsLastRecording(videoRecorder as RecorderModel)
runCatching {
videoRecorder.stopRecording(context)
}
runCatching {
videoRecorder.destroyService(context)
}
showRecorderError = true
} }
} videoRecorder.onRecordingStart = {
videoRecorder.onBatchesFolderNotAccessible = { snackbarHostState.currentSnackbarData?.dismiss()
scope.launch { }
showBatchesInaccessibleError = true videoRecorder.onError = {
scope.launch {
saveAsLastRecording(videoRecorder as RecorderModel)
runCatching { runCatching {
videoRecorder.stopRecording(context) videoRecorder.stopRecording(context)
} }
runCatching { runCatching {
videoRecorder.destroyService(context) videoRecorder.destroyService(context)
}
showRecorderError = true
} }
} }
} videoRecorder.onBatchesFolderNotAccessible = {
scope.launch {
showBatchesInaccessibleError = true
onDispose { runCatching {
Log.d("Alibi", "===== Disposing videoRecorder events") videoRecorder.stopRecording(context)
videoRecorder.onRecordingSave = { }
throw NotImplementedError("onRecordingSave should not be called now") runCatching {
videoRecorder.destroyService(context)
}
}
}
onDispose {
Log.i("Alibi", "===== Disposing videoRecorder events")
videoRecorder.onRecordingSave = {
throw NotImplementedError("onRecordingSave should not be called now")
}
videoRecorder.onError = {}
} }
videoRecorder.onError = {}
} }
} }