Add missing content descriptions

#166
2025-06-18 16:25:27 +02:00 · 2024-01-20 23:38:31 +03:00 · 2024-01-20 23:38:31 +03:00 · 27620e86c5
commit 27620e86c5
parent 9f683785cf
7 changed files with 28 additions and 8 deletions
--- a/core/base/src/main/res/values/strings.xml
+++ b/core/base/src/main/res/values/strings.xml
@ -43,6 +43,10 @@
    <string name="copied_label">Copied %1$s!</string>
    <string name="date_calculator_add">Add</string>

+    <!-- https://s3.eu-west-1.amazonaws.com/po-pub/i/CfdIPBOo2IZnLb0elHvLcUQ3.png -->
+    <!-- Screen readers (accessibility) -->
+    <string name="date_calculator_create_event">Create event</string>
+
    <!-- https://s3.eu-west-1.amazonaws.com/po-pub/i/33QTn2NVrjJT772cBDFRqSMH.png -->
    <string name="date_calculator_days">Days</string>
    <string name="date_calculator_difference">Difference</string>
@ -100,6 +104,11 @@ Used in this dialog window. Should be short -->

    <!-- https://s3.eu-west-1.amazonaws.com/po-pub/i/uWOHJmIq9riqsq7PO82ZQp3a.png -->
    <string name="select_time_label">Select time</string>
+
+    <!-- Used in multiple places (check icons)
+https://s3.eu-west-1.amazonaws.com/po-pub/i/1oIHPj16krI0jyLmg4JaP2mk.png -->
+    <!-- Screen readers (accessibility) -->
+    <string name="selected_item">Selected item</string>
    <string name="settings_about_unitto">About Unitto</string>
    <string name="settings_about_unitto_support">Learn about the app</string>

@ -206,6 +215,11 @@ Maybe this can be labeled better? Let me know. It should be something that can d

    <!-- https://s3.eu-west-1.amazonaws.com/po-pub/i/UCrz06kaEYxCGAE73ZLl9EtX.png -->
    <string name="time_zone_no_results_support">Need more time zones?</string>
+
+    <!-- Description for Reset button
+https://s3.eu-west-1.amazonaws.com/po-pub/i/llhUZ6FzZenWAgtdNAcXfKWn.png -->
+    <!-- Screen readers (accessibility) -->
+    <string name="time_zone_reset">Reset</string>
    <string name="time_zone_title">Time zones</string>
    <string name="tomorrow">Tomorrow</string>
    <string name="unit_acre">Acre</string>
--- a/feature/datecalculator/src/main/java/com/sadellie/unitto/feature/datecalculator/addsubtract/AddSubtractPage.kt
+++ b/feature/datecalculator/src/main/java/com/sadellie/unitto/feature/datecalculator/addsubtract/AddSubtractPage.kt
@ -128,7 +128,7 @@ private fun AddSubtractView(
                ) {
                    Icon(
                        imageVector = Icons.Default.Event,
-                        contentDescription = null,
+                        contentDescription = stringResource(R.string.date_calculator_create_event),
                    )
                }
            },
--- a/feature/settings/src/main/java/com/sadellie/unitto/feature/settings/components/ColorSelector.kt
+++ b/feature/settings/src/main/java/com/sadellie/unitto/feature/settings/components/ColorSelector.kt
@ -49,7 +49,9 @@ import androidx.compose.ui.Modifier
 import androidx.compose.ui.draw.clip
 import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.graphics.luminance
+import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.unit.dp
+import com.sadellie.unitto.core.base.R

@Composable
 internal fun ColorSelector(
@ -122,7 +124,7 @@ private fun ColorCheckbox(
        ) {
            Icon(
                imageVector = Icons.Default.Check,
-                contentDescription = null,
+                contentDescription = stringResource(R.string.selected_item),
                tint = if (color.luminance() > 0.5) Color.Black else Color.White,
            )
        }
--- a/feature/settings/src/main/java/com/sadellie/unitto/feature/settings/components/MonetModeSelector.kt
+++ b/feature/settings/src/main/java/com/sadellie/unitto/feature/settings/components/MonetModeSelector.kt
@ -54,7 +54,9 @@ import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.draw.clip
 import androidx.compose.ui.graphics.Color
+import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.unit.dp
+import com.sadellie.unitto.core.base.R
 import io.github.sadellie.themmo.Themmo
 import io.github.sadellie.themmo.ThemmoController
 import io.github.sadellie.themmo.core.MonetMode
@ -144,7 +146,7 @@ private fun MonetModeCheckbox(
        ) {
            Icon(
                imageVector = Icons.Default.Check,
-                contentDescription = null,
+                contentDescription = stringResource(R.string.selected_item),
                tint = MaterialTheme.colorScheme.inverseOnSurface,
                modifier = Modifier
                    .background(MaterialTheme.colorScheme.inverseSurface, CircleShape)
--- a/feature/timezone/src/main/java/com/sadellie/unitto/feature/timezone/TimeZoneScreen.kt
+++ b/feature/timezone/src/main/java/com/sadellie/unitto/feature/timezone/TimeZoneScreen.kt
@ -75,9 +75,9 @@ import androidx.lifecycle.compose.collectAsStateWithLifecycle
 import com.sadellie.unitto.core.base.R
 import com.sadellie.unitto.core.ui.common.MenuButton
 import com.sadellie.unitto.core.ui.common.SettingsButton
-import com.sadellie.unitto.core.ui.common.datetimepicker.TimePickerDialog
 import com.sadellie.unitto.core.ui.common.UnittoEmptyScreen
 import com.sadellie.unitto.core.ui.common.UnittoScreenWithTopBar
+import com.sadellie.unitto.core.ui.common.datetimepicker.TimePickerDialog
 import com.sadellie.unitto.data.model.timezone.FavoriteZone
 import com.sadellie.unitto.feature.timezone.components.FavoriteTimeZoneItem
 import com.sadellie.unitto.feature.timezone.components.UserTimeZone
@ -189,7 +189,7 @@ private fun TimeZoneScreen(
            ) {
                Icon(
                    imageVector = Icons.Filled.Add,
-                    contentDescription = null,
+                    contentDescription = stringResource(R.string.time_zone_add_title),
                    modifier = Modifier.size(FloatingActionButtonDefaults.LargeIconSize),
                )
            }
--- a/feature/timezone/src/main/java/com/sadellie/unitto/feature/timezone/components/FavoriteTimeZoneItem.kt
+++ b/feature/timezone/src/main/java/com/sadellie/unitto/feature/timezone/components/FavoriteTimeZoneItem.kt
@ -234,7 +234,7 @@ private fun TimeZoneLabel(
                ) {
                    Icon(
                        imageVector = Icons.Default.Edit,
-                        contentDescription = null,
+                        contentDescription = null, // Not required because there is text next to it
                        modifier = Modifier.padding(end = 8.dp),
                    )
                    Text(
@ -250,7 +250,7 @@ private fun TimeZoneLabel(
                AnimatedVisibility(visible = expanded) {
                    Icon(
                        imageVector = Icons.Default.Edit,
-                        contentDescription = null,
+                        contentDescription = null, // Not required because there is text next to it
                        modifier = Modifier.padding(end = 8.dp),
                    )
                }
--- a/feature/timezone/src/main/java/com/sadellie/unitto/feature/timezone/components/UserTimeZone.kt
+++ b/feature/timezone/src/main/java/com/sadellie/unitto/feature/timezone/components/UserTimeZone.kt
@ -46,9 +46,11 @@ import androidx.compose.runtime.remember
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.platform.LocalContext
+import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.style.TextOverflow
 import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.unit.dp
+import com.sadellie.unitto.core.base.R
 import com.sadellie.unitto.core.ui.LocalLocale
 import com.sadellie.unitto.core.ui.common.squashable
 import com.sadellie.unitto.core.ui.datetime.formatDateDayMonthYear
@ -113,7 +115,7 @@ internal fun UserTimeZone(
            IconButton(onResetClick) {
                Icon(
                    imageVector = Icons.Outlined.History,
-                    contentDescription = null,
+                    contentDescription = stringResource(R.string.time_zone_reset),
                    tint = MaterialTheme.colorScheme.onTertiaryContainer,
                )
            }