Myzel394/NumberHub
1
0
Fork 0
mirror of https://github.com/Myzel394/NumberHub.git synced 2025-06-19 08:45:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fixed unit list loading

Browse Source
This commit is contained in:
Sad Ellie 2022-06-12 12:36:10 +03:00
parent 72f6d2e4f7
commit bc55e23e04
2 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/src/main/java/com/sadellie/unitto/screens/MainViewModel.kt
View File

@ -421,6 +421,9 @@ class MainViewModel @Inject constructor(
leftSide: Boolean leftSide: Boolean
) { ) {
viewModelScope.launch { viewModelScope.launch {
// Prevent user from seeing invalid list
unitsToShow = emptyMap()
val filterGroup: Boolean = chosenUnitGroup != null val filterGroup: Boolean = chosenUnitGroup != null
// This is mostly not UI related stuff and viewModelScope.launch uses Dispatchers.Main // This is mostly not UI related stuff and viewModelScope.launch uses Dispatchers.Main

7
app/src/main/java/com/sadellie/unitto/screens/second/SecondScreen.kt
View File

@ -105,13 +105,6 @@ fun SecondScreen(
LaunchedEffect(Unit) { LaunchedEffect(Unit) {
/** /**
* Telling viewModel that it needs to update the list * Telling viewModel that it needs to update the list
* Also while the below is being computed user will composable will use cached list from viewModel
*
* User actually doesn't see cached list. Computation takes few milliseconds since we don't
* compute any Levenshtein distance when the screen is launched and the list is limited
* to a specific [UnitGroup]
*
* Adding animation/spinners will cause flickering and confuse user
*/ */
viewModel.loadUnitsToShow(searchQuery, chosenUnitGroup, leftSide) viewModel.loadUnitsToShow(searchQuery, chosenUnitGroup, leftSide)
// Scrolling chips to current group // Scrolling chips to current group