Myzel394/NumberHub
1
0
Fork 0
mirror of https://github.com/Myzel394/NumberHub.git synced 2025-06-18 16:25:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix factorial of 0

Browse Source 
closes #186
This commit is contained in:
Sad Ellie 2024-02-11 22:58:26 +03:00
parent 5a7fd41cf5
commit ebb5fc52e0
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
data/evaluatto/src/main/java/io/github/sadellie/evaluatto/BigDecimalMath.kt
View File

@ -93,6 +93,8 @@ internal fun BigDecimal.factorial(): BigDecimal {
if (this < BigDecimal.ZERO) throw ExpressionException.FactorialCalculation() if (this < BigDecimal.ZERO) throw ExpressionException.FactorialCalculation()
if (this > maxFactorial) throw ExpressionException.TooBig() if (this > maxFactorial) throw ExpressionException.TooBig()
if (this.compareTo(BigDecimal.ZERO) == 0) return BigDecimal.ONE
var expr = this var expr = this
for (i in 1 until this.toInt()) { for (i in 1 until this.toInt()) {
expr *= BigDecimal(i) expr *= BigDecimal(i)

3
data/evaluatto/src/test/java/io/github/sadellie/evaluatto/ExpressionSimpleTest.kt
View File

@ -108,4 +108,7 @@ class ExpressionSimpleTest {
@Test @Test
fun expression28() = assertExpr("e", "2.7182818285") fun expression28() = assertExpr("e", "2.7182818285")
@Test
fun expression29() = assertExpr("0!", "1")
} }